mirror of
https://github.com/MatomoCamp/matomocamp-companion-android.git
synced 2024-09-19 16:13:46 +02:00
Fixed some Lint warnings
This commit is contained in:
parent
e0440a0ead
commit
c8a1fdef78
10 changed files with 20 additions and 19 deletions
|
@ -87,9 +87,6 @@ public class DividerItemDecoration extends RecyclerView.ItemDecoration {
|
||||||
* @param drawable Drawable that should be used as a divider.
|
* @param drawable Drawable that should be used as a divider.
|
||||||
*/
|
*/
|
||||||
public void setDrawable(@NonNull Drawable drawable) {
|
public void setDrawable(@NonNull Drawable drawable) {
|
||||||
if (drawable == null) {
|
|
||||||
throw new IllegalArgumentException("Drawable cannot be null.");
|
|
||||||
}
|
|
||||||
mDivider = drawable;
|
mDivider = drawable;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -5,6 +5,7 @@ import android.os.Bundle;
|
||||||
import android.preference.PreferenceActivity;
|
import android.preference.PreferenceActivity;
|
||||||
import android.support.annotation.IdRes;
|
import android.support.annotation.IdRes;
|
||||||
import android.support.annotation.LayoutRes;
|
import android.support.annotation.LayoutRes;
|
||||||
|
import android.support.annotation.NonNull;
|
||||||
import android.support.annotation.Nullable;
|
import android.support.annotation.Nullable;
|
||||||
import android.support.v7.app.ActionBar;
|
import android.support.v7.app.ActionBar;
|
||||||
import android.support.v7.app.AppCompatDelegate;
|
import android.support.v7.app.AppCompatDelegate;
|
||||||
|
@ -43,6 +44,7 @@ public class AppCompatPreferenceActivity extends PreferenceActivity {
|
||||||
getDelegate().setSupportActionBar(toolbar);
|
getDelegate().setSupportActionBar(toolbar);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@NonNull
|
||||||
@Override
|
@Override
|
||||||
public MenuInflater getMenuInflater() {
|
public MenuInflater getMenuInflater() {
|
||||||
return getDelegate().getMenuInflater();
|
return getDelegate().getMenuInflater();
|
||||||
|
|
|
@ -73,6 +73,7 @@ public class SettingsActivity extends AppCompatPreferenceActivity implements Sha
|
||||||
findPreference(KEY_PREF_NOTIFICATIONS_DELAY).setEnabled(notificationsEnabled);
|
findPreference(KEY_PREF_NOTIFICATIONS_DELAY).setEnabled(notificationsEnabled);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@SuppressWarnings("deprecation")
|
||||||
private void updateNotificationsDelaySummary() {
|
private void updateNotificationsDelaySummary() {
|
||||||
ListPreference notificationsDelayPreference = (ListPreference) findPreference(KEY_PREF_NOTIFICATIONS_DELAY);
|
ListPreference notificationsDelayPreference = (ListPreference) findPreference(KEY_PREF_NOTIFICATIONS_DELAY);
|
||||||
notificationsDelayPreference.setSummary(notificationsDelayPreference.getEntry());
|
notificationsDelayPreference.setSummary(notificationsDelayPreference.getEntry());
|
||||||
|
|
|
@ -83,9 +83,7 @@ public class TrackScheduleActivity extends AppCompatActivity
|
||||||
|
|
||||||
Fragment eventDetailsFragment = fm.findFragmentById(R.id.event);
|
Fragment eventDetailsFragment = fm.findFragmentById(R.id.event);
|
||||||
if (eventDetailsFragment != null) {
|
if (eventDetailsFragment != null) {
|
||||||
if (ft == null) {
|
|
||||||
ft = fm.beginTransaction();
|
ft = fm.beginTransaction();
|
||||||
}
|
|
||||||
ft.remove(eventDetailsFragment);
|
ft.remove(eventDetailsFragment);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -23,7 +23,7 @@ public class FosdemAlarmManager implements OnSharedPreferenceChangeListener {
|
||||||
|
|
||||||
private static FosdemAlarmManager instance;
|
private static FosdemAlarmManager instance;
|
||||||
|
|
||||||
private Context context;
|
private final Context context;
|
||||||
private boolean isEnabled;
|
private boolean isEnabled;
|
||||||
|
|
||||||
private final BroadcastReceiver scheduleRefreshedReceiver = new BroadcastReceiver() {
|
private final BroadcastReceiver scheduleRefreshedReceiver = new BroadcastReceiver() {
|
||||||
|
|
|
@ -55,8 +55,8 @@ public class DatabaseManager {
|
||||||
|
|
||||||
private static DatabaseManager instance;
|
private static DatabaseManager instance;
|
||||||
|
|
||||||
private Context context;
|
private final Context context;
|
||||||
private DatabaseHelper helper;
|
private final DatabaseHelper helper;
|
||||||
|
|
||||||
private List<Day> cachedDays;
|
private List<Day> cachedDays;
|
||||||
private int year = -1;
|
private int year = -1;
|
||||||
|
|
|
@ -14,7 +14,7 @@ public abstract class IterableAbstractPullParser<T> extends AbstractPullParser<I
|
||||||
|
|
||||||
private class ParserIterator implements Iterator<T> {
|
private class ParserIterator implements Iterator<T> {
|
||||||
|
|
||||||
private XmlPullParser parser;
|
private final XmlPullParser parser;
|
||||||
private T next = null;
|
private T next = null;
|
||||||
|
|
||||||
public ParserIterator(XmlPullParser parser) {
|
public ParserIterator(XmlPullParser parser) {
|
||||||
|
|
|
@ -5,6 +5,7 @@ import android.content.ContentProvider;
|
||||||
import android.content.ContentValues;
|
import android.content.ContentValues;
|
||||||
import android.database.Cursor;
|
import android.database.Cursor;
|
||||||
import android.net.Uri;
|
import android.net.Uri;
|
||||||
|
import android.support.annotation.NonNull;
|
||||||
import android.text.TextUtils;
|
import android.text.TextUtils;
|
||||||
import be.digitalia.fosdem.db.DatabaseManager;
|
import be.digitalia.fosdem.db.DatabaseManager;
|
||||||
|
|
||||||
|
@ -24,27 +25,27 @@ public class SearchSuggestionProvider extends ContentProvider {
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int delete(Uri uri, String selection, String[] selectionArgs) {
|
public int delete(@NonNull Uri uri, String selection, String[] selectionArgs) {
|
||||||
throw new UnsupportedOperationException();
|
throw new UnsupportedOperationException();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Uri insert(Uri uri, ContentValues values) {
|
public Uri insert(@NonNull Uri uri, ContentValues values) {
|
||||||
throw new UnsupportedOperationException();
|
throw new UnsupportedOperationException();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) {
|
public int update(@NonNull Uri uri, ContentValues values, String selection, String[] selectionArgs) {
|
||||||
throw new UnsupportedOperationException();
|
throw new UnsupportedOperationException();
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public String getType(Uri uri) {
|
public String getType(@NonNull Uri uri) {
|
||||||
return SearchManager.SUGGEST_MIME_TYPE;
|
return SearchManager.SUGGEST_MIME_TYPE;
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
|
public Cursor query(@NonNull Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
|
||||||
String query = uri.getLastPathSegment();
|
String query = uri.getLastPathSegment();
|
||||||
// Ignore empty or too small queries
|
// Ignore empty or too small queries
|
||||||
if (query == null) {
|
if (query == null) {
|
||||||
|
|
|
@ -93,7 +93,7 @@ public class HttpUtils {
|
||||||
result.inputStream = new ByteCountInputStream(result.inputStream,
|
result.inputStream = new ByteCountInputStream(result.inputStream,
|
||||||
new ByteCountInputStream.ByteCountListener() {
|
new ByteCountInputStream.ByteCountListener() {
|
||||||
|
|
||||||
private LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context);
|
private final LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context);
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void onNewCount(int byteCount) {
|
public void onNewCount(int byteCount) {
|
||||||
|
|
|
@ -95,10 +95,12 @@ public class StringUtils {
|
||||||
return replaceNonAlphaGroups(trimNonAlpha(removeDiacritics(source)), '_').toLowerCase(Locale.US);
|
return replaceNonAlphaGroups(trimNonAlpha(removeDiacritics(source)), '_').toLowerCase(Locale.US);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@SuppressWarnings("deprecation")
|
||||||
public static String stripHtml(String html) {
|
public static String stripHtml(String html) {
|
||||||
return trimEnd(Html.fromHtml(html)).toString();
|
return trimEnd(Html.fromHtml(html)).toString();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@SuppressWarnings("deprecation")
|
||||||
public static CharSequence parseHtml(String html, Resources res) {
|
public static CharSequence parseHtml(String html, Resources res) {
|
||||||
return trimEnd(Html.fromHtml(html, null, new ListsTagHandler(res)));
|
return trimEnd(Html.fromHtml(html, null, new ListsTagHandler(res)));
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue