diff --git a/app/src/main/java/android/support/v7/widget/DividerItemDecoration.java b/app/src/main/java/android/support/v7/widget/DividerItemDecoration.java index 47490e8..59808f2 100644 --- a/app/src/main/java/android/support/v7/widget/DividerItemDecoration.java +++ b/app/src/main/java/android/support/v7/widget/DividerItemDecoration.java @@ -87,9 +87,6 @@ public class DividerItemDecoration extends RecyclerView.ItemDecoration { * @param drawable Drawable that should be used as a divider. */ public void setDrawable(@NonNull Drawable drawable) { - if (drawable == null) { - throw new IllegalArgumentException("Drawable cannot be null."); - } mDivider = drawable; } diff --git a/app/src/main/java/be/digitalia/fosdem/activities/AppCompatPreferenceActivity.java b/app/src/main/java/be/digitalia/fosdem/activities/AppCompatPreferenceActivity.java index 08d8684..dbbdb3a 100644 --- a/app/src/main/java/be/digitalia/fosdem/activities/AppCompatPreferenceActivity.java +++ b/app/src/main/java/be/digitalia/fosdem/activities/AppCompatPreferenceActivity.java @@ -5,6 +5,7 @@ import android.os.Bundle; import android.preference.PreferenceActivity; import android.support.annotation.IdRes; import android.support.annotation.LayoutRes; +import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.support.v7.app.ActionBar; import android.support.v7.app.AppCompatDelegate; @@ -43,6 +44,7 @@ public class AppCompatPreferenceActivity extends PreferenceActivity { getDelegate().setSupportActionBar(toolbar); } + @NonNull @Override public MenuInflater getMenuInflater() { return getDelegate().getMenuInflater(); diff --git a/app/src/main/java/be/digitalia/fosdem/activities/SettingsActivity.java b/app/src/main/java/be/digitalia/fosdem/activities/SettingsActivity.java index 8351b8f..4520836 100644 --- a/app/src/main/java/be/digitalia/fosdem/activities/SettingsActivity.java +++ b/app/src/main/java/be/digitalia/fosdem/activities/SettingsActivity.java @@ -73,6 +73,7 @@ public class SettingsActivity extends AppCompatPreferenceActivity implements Sha findPreference(KEY_PREF_NOTIFICATIONS_DELAY).setEnabled(notificationsEnabled); } + @SuppressWarnings("deprecation") private void updateNotificationsDelaySummary() { ListPreference notificationsDelayPreference = (ListPreference) findPreference(KEY_PREF_NOTIFICATIONS_DELAY); notificationsDelayPreference.setSummary(notificationsDelayPreference.getEntry()); diff --git a/app/src/main/java/be/digitalia/fosdem/activities/TrackScheduleActivity.java b/app/src/main/java/be/digitalia/fosdem/activities/TrackScheduleActivity.java index fec1953..f6e2ee0 100644 --- a/app/src/main/java/be/digitalia/fosdem/activities/TrackScheduleActivity.java +++ b/app/src/main/java/be/digitalia/fosdem/activities/TrackScheduleActivity.java @@ -83,9 +83,7 @@ public class TrackScheduleActivity extends AppCompatActivity Fragment eventDetailsFragment = fm.findFragmentById(R.id.event); if (eventDetailsFragment != null) { - if (ft == null) { - ft = fm.beginTransaction(); - } + ft = fm.beginTransaction(); ft.remove(eventDetailsFragment); } diff --git a/app/src/main/java/be/digitalia/fosdem/alarms/FosdemAlarmManager.java b/app/src/main/java/be/digitalia/fosdem/alarms/FosdemAlarmManager.java index 2507fcd..f5a25b6 100644 --- a/app/src/main/java/be/digitalia/fosdem/alarms/FosdemAlarmManager.java +++ b/app/src/main/java/be/digitalia/fosdem/alarms/FosdemAlarmManager.java @@ -15,15 +15,15 @@ import be.digitalia.fosdem.services.AlarmIntentService; /** * This class monitors bookmarks and preferences changes to dispatch alarm update work to AlarmIntentService. - * + * * @author Christophe Beyls - * + * */ public class FosdemAlarmManager implements OnSharedPreferenceChangeListener { private static FosdemAlarmManager instance; - private Context context; + private final Context context; private boolean isEnabled; private final BroadcastReceiver scheduleRefreshedReceiver = new BroadcastReceiver() { diff --git a/app/src/main/java/be/digitalia/fosdem/db/DatabaseManager.java b/app/src/main/java/be/digitalia/fosdem/db/DatabaseManager.java index c148f20..8acfa4b 100644 --- a/app/src/main/java/be/digitalia/fosdem/db/DatabaseManager.java +++ b/app/src/main/java/be/digitalia/fosdem/db/DatabaseManager.java @@ -55,8 +55,8 @@ public class DatabaseManager { private static DatabaseManager instance; - private Context context; - private DatabaseHelper helper; + private final Context context; + private final DatabaseHelper helper; private List cachedDays; private int year = -1; diff --git a/app/src/main/java/be/digitalia/fosdem/parsers/IterableAbstractPullParser.java b/app/src/main/java/be/digitalia/fosdem/parsers/IterableAbstractPullParser.java index eebe380..227dc7f 100644 --- a/app/src/main/java/be/digitalia/fosdem/parsers/IterableAbstractPullParser.java +++ b/app/src/main/java/be/digitalia/fosdem/parsers/IterableAbstractPullParser.java @@ -7,14 +7,14 @@ import org.xmlpull.v1.XmlPullParser; /** * An abstract class for easy implementation of an iterable pull parser. - * + * * @author Christophe Beyls */ public abstract class IterableAbstractPullParser extends AbstractPullParser> { private class ParserIterator implements Iterator { - private XmlPullParser parser; + private final XmlPullParser parser; private T next = null; public ParserIterator(XmlPullParser parser) { diff --git a/app/src/main/java/be/digitalia/fosdem/providers/SearchSuggestionProvider.java b/app/src/main/java/be/digitalia/fosdem/providers/SearchSuggestionProvider.java index d3c6615..95c42d8 100644 --- a/app/src/main/java/be/digitalia/fosdem/providers/SearchSuggestionProvider.java +++ b/app/src/main/java/be/digitalia/fosdem/providers/SearchSuggestionProvider.java @@ -5,6 +5,7 @@ import android.content.ContentProvider; import android.content.ContentValues; import android.database.Cursor; import android.net.Uri; +import android.support.annotation.NonNull; import android.text.TextUtils; import be.digitalia.fosdem.db.DatabaseManager; @@ -24,27 +25,27 @@ public class SearchSuggestionProvider extends ContentProvider { } @Override - public int delete(Uri uri, String selection, String[] selectionArgs) { + public int delete(@NonNull Uri uri, String selection, String[] selectionArgs) { throw new UnsupportedOperationException(); } @Override - public Uri insert(Uri uri, ContentValues values) { + public Uri insert(@NonNull Uri uri, ContentValues values) { throw new UnsupportedOperationException(); } @Override - public int update(Uri uri, ContentValues values, String selection, String[] selectionArgs) { + public int update(@NonNull Uri uri, ContentValues values, String selection, String[] selectionArgs) { throw new UnsupportedOperationException(); } @Override - public String getType(Uri uri) { + public String getType(@NonNull Uri uri) { return SearchManager.SUGGEST_MIME_TYPE; } @Override - public Cursor query(Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) { + public Cursor query(@NonNull Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) { String query = uri.getLastPathSegment(); // Ignore empty or too small queries if (query == null) { diff --git a/app/src/main/java/be/digitalia/fosdem/utils/HttpUtils.java b/app/src/main/java/be/digitalia/fosdem/utils/HttpUtils.java index bf29d38..d7a7079 100644 --- a/app/src/main/java/be/digitalia/fosdem/utils/HttpUtils.java +++ b/app/src/main/java/be/digitalia/fosdem/utils/HttpUtils.java @@ -93,7 +93,7 @@ public class HttpUtils { result.inputStream = new ByteCountInputStream(result.inputStream, new ByteCountInputStream.ByteCountListener() { - private LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context); + private final LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context); @Override public void onNewCount(int byteCount) { diff --git a/app/src/main/java/be/digitalia/fosdem/utils/StringUtils.java b/app/src/main/java/be/digitalia/fosdem/utils/StringUtils.java index c61b2ef..0c8925e 100644 --- a/app/src/main/java/be/digitalia/fosdem/utils/StringUtils.java +++ b/app/src/main/java/be/digitalia/fosdem/utils/StringUtils.java @@ -95,10 +95,12 @@ public class StringUtils { return replaceNonAlphaGroups(trimNonAlpha(removeDiacritics(source)), '_').toLowerCase(Locale.US); } + @SuppressWarnings("deprecation") public static String stripHtml(String html) { return trimEnd(Html.fromHtml(html)).toString(); } + @SuppressWarnings("deprecation") public static CharSequence parseHtml(String html, Resources res) { return trimEnd(Html.fromHtml(html, null, new ListsTagHandler(res))); }