1
0
Fork 0
mirror of https://github.com/MatomoCamp/matomocamp-companion-android.git synced 2024-09-19 16:13:46 +02:00

Use SharedPreferencesCompat.EditorCompat to use apply() when available for better performance.

This commit is contained in:
Christophe Beyls 2016-08-06 01:27:03 +02:00
parent 23c071743f
commit fc82441c9a
4 changed files with 21 additions and 8 deletions

View file

@ -27,6 +27,7 @@ import android.support.v4.app.FragmentManager;
import android.support.v4.app.FragmentTransaction; import android.support.v4.app.FragmentTransaction;
import android.support.v4.content.ContextCompat; import android.support.v4.content.ContextCompat;
import android.support.v4.content.LocalBroadcastManager; import android.support.v4.content.LocalBroadcastManager;
import android.support.v4.content.SharedPreferencesCompat;
import android.support.v4.view.GravityCompat; import android.support.v4.view.GravityCompat;
import android.support.v4.view.MenuItemCompat; import android.support.v4.view.MenuItemCompat;
import android.support.v4.widget.DrawerLayout; import android.support.v4.widget.DrawerLayout;
@ -335,7 +336,9 @@ public class MainActivity extends AppCompatActivity implements Handler.Callback
SharedPreferences prefs = getPreferences(Context.MODE_PRIVATE); SharedPreferences prefs = getPreferences(Context.MODE_PRIVATE);
time = prefs.getLong(PREF_LAST_DOWNLOAD_REMINDER_TIME, -1L); time = prefs.getLong(PREF_LAST_DOWNLOAD_REMINDER_TIME, -1L);
if ((time == -1L) || (time < (now - DOWNLOAD_REMINDER_SNOOZE_DURATION))) { if ((time == -1L) || (time < (now - DOWNLOAD_REMINDER_SNOOZE_DURATION))) {
prefs.edit().putLong(PREF_LAST_DOWNLOAD_REMINDER_TIME, now).commit(); SharedPreferencesCompat.EditorCompat.getInstance().apply(
prefs.edit().putLong(PREF_LAST_DOWNLOAD_REMINDER_TIME, now)
);
FragmentManager fm = getSupportFragmentManager(); FragmentManager fm = getSupportFragmentManager();
if (fm.findFragmentByTag("download_reminder") == null) { if (fm.findFragmentByTag("download_reminder") == null) {

View file

@ -22,6 +22,7 @@ import android.database.sqlite.SQLiteStatement;
import android.net.Uri; import android.net.Uri;
import android.provider.BaseColumns; import android.provider.BaseColumns;
import android.support.v4.content.LocalBroadcastManager; import android.support.v4.content.LocalBroadcastManager;
import android.support.v4.content.SharedPreferencesCompat;
import android.text.TextUtils; import android.text.TextUtils;
import be.digitalia.fosdem.model.Day; import be.digitalia.fosdem.model.Day;
@ -268,10 +269,11 @@ public class DatabaseManager {
cachedDays = null; cachedDays = null;
year = -1; year = -1;
// Set last update time and server's last modified tag // Set last update time and server's last modified tag
SharedPreferencesCompat.EditorCompat.getInstance().apply(
getSharedPreferences().edit() getSharedPreferences().edit()
.putLong(LAST_UPDATE_TIME_PREF, System.currentTimeMillis()) .putLong(LAST_UPDATE_TIME_PREF, System.currentTimeMillis())
.putString(LAST_MODIFIED_TAG_PREF, lastModifiedTag) .putString(LAST_MODIFIED_TAG_PREF, lastModifiedTag)
.commit(); );
context.getContentResolver().notifyChange(URI_TRACKS, null); context.getContentResolver().notifyChange(URI_TRACKS, null);
context.getContentResolver().notifyChange(URI_EVENTS, null); context.getContentResolver().notifyChange(URI_EVENTS, null);
@ -290,7 +292,9 @@ public class DatabaseManager {
cachedDays = null; cachedDays = null;
year = -1; year = -1;
getSharedPreferences().edit().remove(LAST_UPDATE_TIME_PREF).commit(); SharedPreferencesCompat.EditorCompat.getInstance().apply(
getSharedPreferences().edit().remove(LAST_UPDATE_TIME_PREF)
);
} finally { } finally {
db.endTransaction(); db.endTransaction();

View file

@ -8,6 +8,7 @@ import android.os.Bundle;
import android.os.Handler; import android.os.Handler;
import android.support.v4.app.LoaderManager.LoaderCallbacks; import android.support.v4.app.LoaderManager.LoaderCallbacks;
import android.support.v4.content.Loader; import android.support.v4.content.Loader;
import android.support.v4.content.SharedPreferencesCompat;
import android.view.Menu; import android.view.Menu;
import android.view.MenuInflater; import android.view.MenuInflater;
import android.view.MenuItem; import android.view.MenuItem;
@ -103,7 +104,9 @@ public class BookmarksListFragment extends SmoothListFragment implements LoaderC
case R.id.upcoming_only: case R.id.upcoming_only:
upcomingOnly = !upcomingOnly; upcomingOnly = !upcomingOnly;
updateOptionsMenu(); updateOptionsMenu();
getActivity().getPreferences(Context.MODE_PRIVATE).edit().putBoolean(PREF_UPCOMING_ONLY, upcomingOnly).commit(); SharedPreferencesCompat.EditorCompat.getInstance().apply(
getActivity().getPreferences(Context.MODE_PRIVATE).edit().putBoolean(PREF_UPCOMING_ONLY, upcomingOnly)
);
getLoaderManager().restartLoader(BOOKMARKS_LOADER_ID, null, this); getLoaderManager().restartLoader(BOOKMARKS_LOADER_ID, null, this);
return true; return true;
} }

View file

@ -12,6 +12,7 @@ import android.support.v4.app.FragmentStatePagerAdapter;
import android.support.v4.app.LoaderManager.LoaderCallbacks; import android.support.v4.app.LoaderManager.LoaderCallbacks;
import android.support.v4.content.Loader; import android.support.v4.content.Loader;
import android.support.v4.content.LocalBroadcastManager; import android.support.v4.content.LocalBroadcastManager;
import android.support.v4.content.SharedPreferencesCompat;
import android.support.v4.view.ViewPager; import android.support.v4.view.ViewPager;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
@ -86,7 +87,9 @@ public class TracksFragment extends Fragment implements LoaderCallbacks<List<Day
final int page = holder.pager.getCurrentItem(); final int page = holder.pager.getCurrentItem();
SharedPreferences prefs = getActivity().getPreferences(Context.MODE_PRIVATE); SharedPreferences prefs = getActivity().getPreferences(Context.MODE_PRIVATE);
if (prefs.getInt(PREF_CURRENT_PAGE, -1) != page) { if (prefs.getInt(PREF_CURRENT_PAGE, -1) != page) {
prefs.edit().putInt(PREF_CURRENT_PAGE, page).commit(); SharedPreferencesCompat.EditorCompat.getInstance().apply(
prefs.edit().putInt(PREF_CURRENT_PAGE, page)
);
} }
} }