1
0
Fork 0

remove no longer used github client secret

This commit is contained in:
sgiehl 2022-02-02 18:10:55 +01:00
parent 2154a1dbac
commit 8891735532
No known key found for this signature in database
GPG key ID: 6C85A2863D997A05
3 changed files with 2 additions and 3 deletions

View file

@ -22,7 +22,6 @@ define('PROJECT_EMAIL', 'developer@matomo.org');
* On the screen you don't need to give any permission. The default view public info permission is good enough. * On the screen you don't need to give any permission. The default view public info permission is good enough.
*/ */
define('GITHUB_CLIENT_ID', ''); define('GITHUB_CLIENT_ID', '');
define('GITHUB_CLIENT_SECRET', '');
define('GITHUB_ORGANIZATION', 'matomo-org'); define('GITHUB_ORGANIZATION', 'matomo-org');
define('GITHUB_REPOSITORY', 'matomo'); define('GITHUB_REPOSITORY', 'matomo');
define('NUMBER_OF_ISSUES_PER_PAGE', 100); define('NUMBER_OF_ISSUES_PER_PAGE', 100);

View file

@ -47,7 +47,7 @@ class GithubImporter {
} }
} }
public static function buildClient($clientId, $clientSecret) public static function buildClient($clientId)
{ {
$filesystemAdapter = new Local(realpath('../tmp/github_api_cache')); $filesystemAdapter = new Local(realpath('../tmp/github_api_cache'));
$filesystem = new Filesystem($filesystemAdapter); $filesystem = new Filesystem($filesystemAdapter);

View file

@ -23,7 +23,7 @@ if (DEBUG_ENABLED) {
} }
$logger->info("authenticating"); $logger->info("authenticating");
$client = helpers\GithubImporter::buildClient(GITHUB_CLIENT_ID, GITHUB_CLIENT_SECRET); $client = helpers\GithubImporter::buildClient(GITHUB_CLIENT_ID);
$importer = new helpers\GithubImporter($client, $logger); $importer = new helpers\GithubImporter($client, $logger);
try { try {